feat: improve logging system to filter markers #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Mar 13, 2024
Comment on lines
+581
to
+582
| final LogMarkerFilter markerFilter = new LogMarkerFilter(); | ||
|
|
There was a problem hiding this comment.
This will ignore all log entries that are marked because nothing is supplied to the constructor. Later we may enable some markers in debug builds.
HashEngineering
commented
Mar 18, 2024
Comment on lines
-123
to
+124
| const val DEFAULT_SESSIONS = 4 | ||
| const val DEFAULT_SESSIONS = 6 |
There was a problem hiding this comment.
This was the only speed related changed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Add log marker filers. Marked logs are by default ignored.
Improve CoinJoin speed by up to 50%
Related PR's and Dependencies
dashpay/dashj#248
Screenshots / Videos
How Has This Been Tested?
Checklist: