Dashpay 11.0.3 fixes #1323
Merged
Dashpay 11.0.3 fixes #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Nov 12, 2024
Comment on lines
-170
to
+181
| val storageManager = applicationContext.getSystemService<StorageManager>()!! | ||
| val storageUUID = storageManager.getUuidForPath(filesDir) | ||
| val availableBytes = storageManager.getAllocatableBytes(storageUUID) | ||
| val toleranceInBytes = 1024L * 1024 * STORAGE_TOLERANCE | ||
| lifecycleScope.launch { | ||
| val storageManager = applicationContext.getSystemService<StorageManager>()!! | ||
| val availableBytes = withContext(Dispatchers.IO) { | ||
| val storageUUID = storageManager.getUuidForPath(filesDir) | ||
| storageManager.getAllocatableBytes(storageUUID) | ||
| } | ||
| val toleranceInBytes = 1024L * 1024 * STORAGE_TOLERANCE | ||
|
|
||
| if (availableBytes <= toleranceInBytes && !lowStorageDialogShown) { | ||
| lowStorageDialogShown = true | ||
| showLowStorageAlertDialog() | ||
| if (availableBytes <= toleranceInBytes && !lowStorageDialogShown) { | ||
| lowStorageDialogShown = true | ||
| showLowStorageAlertDialog() | ||
| } |
There was a problem hiding this comment.
This is to avoid an ANR
HashEngineering
commented
Nov 12, 2024
Comment on lines
+1145
to
-1148
| // remove request | ||
| usernameRequestDao.remove(request.requestId) | ||
| // remove related votes | ||
| usernameVoteDao.remove(request.normalizedLabel) | ||
| } | ||
| // remove related votes | ||
| usernameVoteDao.remove(request.normalizedLabel) |
There was a problem hiding this comment.
Before our records of username votes were getting removed even though voting wasn't finished.
HashEngineering
commented
Nov 13, 2024
Comment on lines
+128
to
+134
| fun broadcastUpdateProfile( | ||
| displayName: String, | ||
| publicMessage: String, | ||
| avatarUrl: String, | ||
| uploadService: String = "", | ||
| localAvatarUrl: String = "" | ||
| ) { |
There was a problem hiding this comment.
This file has only style changes
HashEngineering
commented
Nov 13, 2024
Comment on lines
-52
to
-54
| binding.requestUsernameButton.isEnabled = username.isNotEmpty() && | ||
| requestUserNameViewModel.canAffordNonContestedUsername() | ||
|
|
There was a problem hiding this comment.
This was removed because it is handled in the uiState observer. This code would allow the user to click "Request Username" before the validation of the name was completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: