fix: optimize report #1333
Merged
fix: optimize report #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allet into bugfix-optimize-report
HashEngineering
commented
Dec 25, 2024
Comment on lines
-373
to
-387
| private fun showLowStorageAlertDialog() { | ||
| baseAlertDialogBuilder.title = getString(R.string.wallet_low_storage_dialog_title) | ||
| baseAlertDialogBuilder.message = getString(R.string.wallet_low_storage_dialog_msg) | ||
| baseAlertDialogBuilder.positiveText = | ||
| getString(R.string.wallet_low_storage_dialog_button_apps) | ||
| baseAlertDialogBuilder.positiveAction = { | ||
| startActivity(Intent(Settings.ACTION_MANAGE_APPLICATIONS_SETTINGS)) | ||
| finish() | ||
| } | ||
| baseAlertDialogBuilder.negativeText = getString(R.string.button_dismiss) | ||
| baseAlertDialogBuilder.showIcon = true | ||
| alertDialog = baseAlertDialogBuilder.buildAlertDialog() | ||
| alertDialog.show() | ||
| } | ||
|
|
There was a problem hiding this comment.
This function is not used and was replaced.
HashEngineering
added a commit
that referenced
this pull request
Jan 16, 2025
#1331) * feat: update tx list with observeTransactions * fix: improve WalletBalanceObserver * fix: remove update functions from TransactionRowView * fix: use TransactionRowViewList * fix: improve TX details * fix: more improvements to MainViewModel * fix: problems showing Tx details and going to home screen afterwards * fix: always submit a new list for the UI * fix: add reset listener * fix: batch updates * fix: replace batch updates method and only process tx confidence changes for the past hour of tx's * fix: update dashj to 21.1.5-SNAPSHOT * chore: refactor telephony manager usage * chore: upgrade gradle & AGP * fix: optimize contact support report and change wifi warning(#1333) * feat: add ContactSupportDialogFragment and ViewModel * feat: use ContactSupportDialogFragment * fix: improve wallet dump * fix: sort logFiles by most recent date first, then limit to 20MB * fix: disable auto logout when creating report * chore: remove ReportIssueDialogBuilder * fix: update wifi warning for mixing fees (#1334) * fix: mixing icon and row view id type * chore: upgrade kotlin & ksp to fix deadlock * feat: performance, uncoupling metadata & contacts * fix: confirmation dialog UI with contact * fix: observing contacts bugs * fix: send to contact from send tab * fix: sticky info panel on EnterAmountFragment * fix: more proguard rules * fix: log date format attempted fix * fix: attempting to fix log date format * fix: add logback to proguard * fix: proper isComplete check for CrowdNode tx set * fix: change the way topup tx observed for CrowdNode * fix: build error - missing file * fix: proguard fixes * fix: check if identity is null in observeContacts --------- Co-authored-by: Andrei Ashikhmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: