Prepare release 11.1 #1342
Merged
Prepare release 11.1 #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Jan 23, 2025
Comment on lines
1277
to
1289
| // unregister receivers on the main thread | ||
| unregisterReceiver(tickReceiver) | ||
| unregisterReceiver(connectivityReceiver) | ||
| cleanupDeferred = CompletableDeferred() | ||
| serviceScope.launch { | ||
| try { | ||
| onCreateCompleted.await() // wait until onCreate is finished | ||
| WalletApplication.scheduleStartBlockchainService(this@BlockchainServiceImpl) //disconnect feature | ||
| unregisterReceiver(tickReceiver) | ||
| application.wallet!!.removeChangeEventListener(walletEventListener) | ||
| application.wallet!!.removeCoinsSentEventListener(walletEventListener) | ||
| application.wallet!!.removeCoinsReceivedEventListener(walletEventListener) | ||
| config.unregisterOnSharedPreferenceChangeListener(sharedPrefsChangeListener) | ||
| unregisterReceiver(connectivityReceiver) | ||
| platformSyncService.shutdown() |
There was a problem hiding this comment.
This change is to solve problems with unregistering receivers. There were exceptions about leaking receivers and unregistering receivers that were not registered.
This was probably a result of running the cleanup in a coroutine instead of before onDestroy finishes execution.
Service de.schildbach.wallet.service.BlockchainServiceImpl has leaked IntentReceiver de.schildbach.wallet.service.BlockchainServiceImpl$tickReceiver$1@3257bc5 that was originally registered here. Are you missing a call to unregisterReceiver()?
android.app.IntentReceiverLeaked: Service de.schildbach.wallet.service.BlockchainServiceImpl has leaked IntentReceiver de.schildbach.wallet.service.BlockchainServiceImpl$tickReceiver$1@3257bc5 that was originally registered here. Are you missing a call to unregisterReceiver()?
at android.app.LoadedApk$ReceiverDispatcher.<init>(LoadedApk.java:1839)
at android.app.LoadedApk.getReceiverDispatcher(LoadedApk.java:1601)
at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1840)
at android.app.ContextImpl.registerReceiver(ContextImpl.java:1792)
at android.app.ContextImpl.registerReceiver(ContextImpl.java:1780)
at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:755)
at de.schildbach.wallet.service.BlockchainServiceImpl$onCreate$1.invokeSuspend(BlockchainServiceImpl.kt:1097)
HashEngineering
commented
Jan 27, 2025
Comment on lines
-414
to
+417
| .flatMapLatest { _ -> | ||
| init() | ||
|
|
||
| if (!hasIdentity) { | ||
| return@flatMapLatest flowOf(emptyList()) | ||
| } | ||
|
|
||
| val userId = blockchainIdentity.uniqueIdString | ||
| .filter { it.creationState >= BlockchainIdentityData.CreationState.DONE } | ||
| .flatMapLatest { identityData -> | ||
| val userId = identityData.userId!! |
There was a problem hiding this comment.
Found a crash due during wallet restoration. Let's make sure that restoration of the identity is finished first.
* registration of receivers * check() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: