Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lgtm: part6 #161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Lgtm: part6 #161

wants to merge 4 commits into from

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0ce9035) 48.00% compared to head (1b2b349) 45.10%.

❗ Current head 1b2b349 differs from pull request most recent head eb20624. Consider uploading reports for the commit eb20624 to get more accurate results

Files Patch % Lines
...n/java/org/bitcoinj/governance/GovernanceVote.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #161      +/-   ##
============================================
- Coverage     48.00%   45.10%   -2.90%     
+ Complexity     6666     5327    -1339     
============================================
  Files           409      379      -30     
  Lines         46110    41452    -4658     
  Branches       6502     5658     -844     
============================================
- Hits          22136    18698    -3438     
+ Misses        21570    20800     -770     
+ Partials       2404     1954     -450     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants