Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore deprecated lodash.get #2441

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jan 24, 2025

Issue being fixed or feature implemented

└─ lodash.get
   ├─ ID: lodash.get (deprecation)
   ├─ Issue: This package is deprecated. Use the optional chaining (?.) operator instead.
   ├─ Severity: moderate
   ├─ Vulnerable Versions: 4.4.2
   │ 
   ├─ Tree Versions
   │  └─ 4.4.2
   │ 
   └─ Dependents
      └─ @sinonjs/samsam@npm:8.0.0

What was done?

  • Ignored the deprecation warning

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated package audit configuration to exclude deprecated lodash.get package
    • Added a note about future replacement with optional chaining operator

Copy link
Contributor

coderabbitai bot commented Jan 24, 2025

Walkthrough

The pull request introduces a modification to the .yarnrc.yml configuration file by adding lodash.get to the npmAuditExcludePackages list. This change marks the lodash.get package as deprecated and suggests a future replacement using the optional chaining (?.) operator. The modification is minimal and focused on managing package audit exclusions.

Changes

File Change Summary
.yarnrc.yml Added lodash.get to npmAuditExcludePackages with a TODO comment about deprecation

Possibly related PRs

Suggested reviewers

  • QuantumExplorer
  • lklimek

Poem

🐰 A yarn config update, oh so neat
Lodash.get marked for a swift retreat
Optional chaining waits in the wing
Deprecation's gentle, rabbit-like swing
Code evolves with each small change we bring! 🔧


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.yarnrc.yml (1)

26-26: LGTM! Consider creating an issue to track the migration.

The temporary solution to exclude the deprecated package is reasonable. However, to ensure this technical debt is properly tracked, consider creating a dedicated issue for migrating from lodash.get to the optional chaining operator.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd1527d and 6ff3a9e.

📒 Files selected for processing (1)
  • .yarnrc.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
  • GitHub Check: Build JS packages / Build JS
🔇 Additional comments (1)
.yarnrc.yml (1)

26-26: Would you like help identifying lodash.get usage?

I can help identify all occurrences of lodash.get in the codebase to assess the scope of the migration.

@shumkov shumkov merged commit 764684b into v2.0-dev Jan 24, 2025
18 checks passed
@shumkov shumkov deleted the chore/lodash-get-deprecated branch January 24, 2025 10:57
@thephez thephez added this to the v2.0.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants