Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infographics cache for street - reduce run time #2699

Closed
atalyaalon opened this issue Sep 8, 2024 · 3 comments · Fixed by #2718
Closed

Infographics cache for street - reduce run time #2699

atalyaalon opened this issue Sep 8, 2024 · 3 comments · Fixed by #2718
Assignees
Milestone

Comments

@atalyaalon
Copy link
Collaborator

atalyaalon commented Sep 8, 2024

Between 10.8.24 and 17.8.24 we merged prs to master (I believe it's this one) that increased streets cache loading by a significant amount.

(See loading times for the last task here- fill-infographics-cache-for-streets)

Debug this issue to reduce to previous run time (or less)

@atalyaalon atalyaalon added this to the v0.19.0 milestone Sep 8, 2024
@atalyaalon atalyaalon changed the title Infographics cache for street - long loading time Infographics cache for street - reduce run time Sep 8, 2024
@atalyaalon
Copy link
Collaborator Author

@ziv17 this is your next issue :) let me know if you need anything

@ziv17
Copy link
Collaborator

ziv17 commented Oct 18, 2024

Hi @atalyaalon ,
I forgot to add index to street1/2 to involved_markers_hebrew. I think this is one of the major reasons.
I found a couple of additional small items to change to reduce time. I will prepare a PR.

@atalyaalon
Copy link
Collaborator Author

@ziv17 great, thanks for the update!

@atalyaalon atalyaalon linked a pull request Oct 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants