Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve street cache update time #2718

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Oct 20, 2024

#2699m Add street numeric indexes to involved_markers_hebrew and two additional small improvements

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (400af13) to head (018599d).
Report is 128 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/parsers/infographics_data_cache_updater.py 0.00% 7 Missing ⚠️
anyway/widgets/widget.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2718      +/-   ##
==========================================
- Coverage   53.22%   52.88%   -0.34%     
==========================================
  Files         119      122       +3     
  Lines        9924    10146     +222     
==========================================
+ Hits         5282     5366      +84     
- Misses       4642     4780     +138     
Flag Coverage Δ
unittests 52.88% <20.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 force-pushed the 2699-street-cache branch 2 times, most recently from 079af8a to 3ac6abc Compare October 20, 2024 13:22
@ziv17 ziv17 force-pushed the 2699-street-cache branch from 3ac6abc to 018599d Compare October 20, 2024 13:35
@ziv17 ziv17 marked this pull request as ready for review October 20, 2024 16:09
@ziv17 ziv17 requested a review from atalyaalon October 20, 2024 16:10
@atalyaalon atalyaalon linked an issue Oct 20, 2024 that may be closed by this pull request
@atalyaalon atalyaalon merged commit 34b2d8e into data-for-change:dev Oct 20, 2024
3 checks passed
@atalyaalon
Copy link
Collaborator

atalyaalon commented Oct 20, 2024

@ziv17 great work!!
Merging to production

@ziv17 ziv17 deleted the 2699-street-cache branch October 21, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infographics cache for street - reduce run time
3 participants