Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix safety data involve query issues #2775

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Feb 16, 2025

Closes issue #2774

  1. Stream query results
  2. Fix joins with type tables.

This PR includes also #2773

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 54.30%. Comparing base (07a333b) to head (a45c46f).
Report is 21 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/flask_app.py 0.00% 9 Missing ⚠️
anyway/views/safety_data/city_query.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2775      +/-   ##
==========================================
+ Coverage   52.57%   54.30%   +1.73%     
==========================================
  Files         122      126       +4     
  Lines       10232    10658     +426     
==========================================
+ Hits         5379     5788     +409     
- Misses       4853     4870      +17     
Flag Coverage Δ
unittests 54.30% <0.00%> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 changed the title Fix joins in safety data involved query Fix safety data involve query issues Feb 16, 2025
@ziv17 ziv17 requested a review from atalyaalon February 16, 2025 09:57
@ziv17 ziv17 marked this pull request as ready for review February 16, 2025 09:58
@atalyaalon atalyaalon merged commit e0cef67 into data-for-change:dev Feb 19, 2025
3 checks passed
@atalyaalon atalyaalon linked an issue Feb 19, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safety data involved issues
3 participants