Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.0 #159

Merged
merged 60 commits into from
Jan 3, 2025
Merged

Release v0.9.0 #159

merged 60 commits into from
Jan 3, 2025

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Nov 26, 2024

This pull request includes several changes to the bedhost backend and the UI components. The most important changes include the addition of new API endpoints, refactoring of existing code, and updates to the UI for better user experience.

Changes:

  • Added a new class CreateBEDsetRequest in bedhost/data_models.py to handle BEDset creation requests.
  • Introduced a new API endpoint /v1/bed/{bed_id}/neighbours to get nearest neighbors for a BED record in bedhost/routers/bed_api.py.
  • Implemented a new API endpoint /v1/bedset/create/ to create a new BEDset by providing a registry path to the PEPhub project in bedhost/routers/bedset_api.py.
  • Refactored text_to_bed_search function to include additional logic for handling specific queries in bedhost/routers/bed_api.py.

UI Changes:

  • Added Most similar files table to bed page
  • Improved Mobile friendly ui to both bed and bedset page
  • Improved metadata tables on bed page
  • Added Download pdf button for plots
  • Improved search tables
  • Added creation of bedset UI

Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2024

Deploying bedhost-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1215618
Status: ✅  Deploy successful!
Preview URL: https://17e50dda.bedhost.pages.dev
Branch Preview URL: https://dev.bedhost.pages.dev

View logs

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots to go through... I did the best I could. I trust the CSS changes look ok and make sense, so I was just focused more on logic, TypeScript, and python stuff

bedhost/routers/bed_api.py Show resolved Hide resolved
bedhost/routers/bed_api.py Outdated Show resolved Hide resolved
bedhost/routers/bedset_api.py Show resolved Hide resolved
bedhost/routers/bedset_api.py Show resolved Hide resolved
bedhost/routers/bedset_api.py Outdated Show resolved Hide resolved
Comment on lines +55 to +64
const handleSubmit = async () => {
try {
await axios.post(API_ENDPOINT, { registry_path: inputValue });
setMessage('Successfully created BEDset!');
} catch (error) {
const err = error as Error & { response?: { data?: { detail?: string } } };
const errorMessage = err.response?.data?.detail || err.message;
setMessage(`! Unable to create BEDset. ${errorMessage}`);
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bigger discussion than a PR review, but we probably eventually want to convert this to a useMutation implementation. Also, can anyone submit a bedset?

ui/src/components/modals/create-bedset-modal.tsx Outdated Show resolved Hide resolved
ui/src/queries/useBedSetBedfiles.ts Show resolved Hide resolved
ui/src/queries/useBedsetMetadata.ts Show resolved Hide resolved
@khoroshevskyi khoroshevskyi merged commit 4da3297 into master Jan 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants