-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.9.0 #159
Release v0.9.0 #159
Conversation
Add basic table for similar bed files and pdf download button for plots
Added endpoint and ui modal that creates bedsets
Deploying bedhost-ui with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots to go through... I did the best I could. I trust the CSS changes look ok and make sense, so I was just focused more on logic, TypeScript, and python stuff
const handleSubmit = async () => { | ||
try { | ||
await axios.post(API_ENDPOINT, { registry_path: inputValue }); | ||
setMessage('Successfully created BEDset!'); | ||
} catch (error) { | ||
const err = error as Error & { response?: { data?: { detail?: string } } }; | ||
const errorMessage = err.response?.data?.detail || err.message; | ||
setMessage(`! Unable to create BEDset. ${errorMessage}`); | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bigger discussion than a PR review, but we probably eventually want to convert this to a useMutation
implementation. Also, can anyone submit a bedset?
This pull request includes several changes to the
bedhost
backend and the UI components. The most important changes include the addition of new API endpoints, refactoring of existing code, and updates to the UI for better user experience.Changes:
CreateBEDsetRequest
inbedhost/data_models.py
to handle BEDset creation requests./v1/bed/{bed_id}/neighbours
to get nearest neighbors for a BED record inbedhost/routers/bed_api.py
./v1/bedset/create/
to create a new BEDset by providing a registry path to the PEPhub project inbedhost/routers/bedset_api.py
.text_to_bed_search
function to include additional logic for handling specific queries inbedhost/routers/bed_api.py
.UI Changes:
Download pdf
button for plots