Populate missing bundle config reference doc descriptions and fix resource reference doc template #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliacrawf-db
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
juliacrawf-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Thank you!
@ilyakuz-db Can you take a look as well?
The CI failures should be fixable with:
make schema
ilyakuz-db
approved these changes
Feb 10, 2025
| "type": | ||
| "description": |- | ||
| Required. The type of the artifact. | ||
| Required if the artifact is a Python wheel. The type of the artifact. Valid values are `whl` and `jar`. |
There was a problem hiding this comment.
This probably should go into markdown_description field below to fully support code highlighting
Or at least markdown description should be removed/updated because it still says Valid values are whl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests