Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library error reference #767

Closed
wants to merge 2 commits into from

Conversation

kishaningithub
Copy link

Changes

Fix error reference to point to this library instead of the equivalent go version

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@renaudhartert-db
Copy link
Contributor

renaudhartert-db commented Sep 29, 2024

Hi @kishaningithub, thank you for the PR!

Before we can accept and merge it, we would need two things from you:

  1. Our repository only accepts signed commits, could you "back-sign" the commits so that these appear as "verified"?
  2. We would need you to consent with to DCO. You can easily do that by following the steps in our contribution guidelines.

I'll proceed with approving and merging the PR once these two things are done.

Thanks!

@kishaningithub
Copy link
Author

kishaningithub commented Oct 30, 2024

I think #799 is a better fix for this than this PR. Hence i am closing this PR in favour of that

@kishaningithub kishaningithub deleted the patch-1 branch October 30, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants