Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload datasets #1458

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Preload datasets #1458

merged 5 commits into from
Nov 20, 2024
+296 −118

Conversation

ilia-db
Copy link
Contributor

@ilia-db ilia-db commented Nov 20, 2024 •
edited
Loading

Changes

  • Preload recent updates and their events when opening partial refresh Quick Pick
  • Add warning if the Full Refresh option is selected (the same we show in the workspace UI)
  • Fix small bug with run state (which I introduced in the previous PR)

Screen Recording 2024-11-20 at 11 28 19

Tests

Manually and existing tests

@ilia-db ilia-db requested a review from fjakobs November 20, 2024 10:31
@github-actions GitHub Actions
Copy link
Contributor

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/vscode

Inputs:

  • PR number: 1458
  • Commit SHA: ea9501c72cbd16de1e1ff94c6c6db9078d3fbbf6

Checks will be approved automatically on success.

@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11933133956

@ilia-db ilia-db merged commit 910dccb into main Nov 20, 2024
6 checks passed
@ilia-db ilia-db deleted the preload-datasets branch November 20, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjakobs fjakobs fjakobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilia-db @eng-dev-ecosystem-bot @fjakobs