Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #68

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Improve README #68

merged 2 commits into from
Jun 6, 2024

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 6, 2024

No description provided.

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Non-blocking question on the way that tapping works for older versions of the CLI.

If you need to install an older version of the Databricks CLI, you can do so with:

```bash
brew tap-new databricks/tap-old
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a normal SOP for Homebrew tap users? It seems very cumbersome.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not possible to extract into the same tap where it is defined:

% brew extract --version=0.218.0 databricks/tap/databricks databricks/tap
Error: Cannot extract formula to the same tap!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is really a workaround -- Homebrew has first-class support for multiple versions of the same tap as long as you keep all versions as a separate file in the "Formula" directory. I don't think that's worth it for us (yet?).

@pietern pietern added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit cc5cb90 Jun 6, 2024
2 checks passed
@pietern pietern deleted the improve-readme branch June 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants