minor change to deploy.py.tmpl to fix the duplicated alias assigned to the created model in UC #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change all alias to lower case, mlflow UC model registry does not different upper/lower case in alias. The original code leads to model in UC have both alias "champion" and "challenger"
|
@yinxi-db bit confused, if aliases are case-insensitive, wouldn't this change be a no-op? Have we confirmed this works? |
yes, see the registered model here. Without the change, it will create a version with 2 alias as shown in the screenshot earlier and with the update, version 3 has the alias |
arpitjasa-db
reviewed
Jun 6, 2024
| @@ -41,20 +41,20 @@ def deploy(model_uri, env): | |||
| _, model_name, version = model_uri.split("/") | |||
| client = MlflowClient(registry_uri="databricks-uc") | |||
| mv = client.get_model_version(model_name, version) | |||
| target_alias = "Champion" | |||
| target_alias = "champion" | |||
There was a problem hiding this comment.
Can we change the other places in the Stack as well where use Champion or Challenger like the batch inference and model validation notebooks?
|
This was done as part of #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change all alias to lower case, mlflow UC model registry does not different upper/lower case in alias. The original code leads to model in UC have both alias "champion" and "challenger"
