Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata file to link to CLI deploy #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add metadata file to link to CLI deploy #170

wants to merge 1 commit into from

Conversation

arpitjasa-db
Copy link
Collaborator

No description provided.

@@ -0,0 +1,11 @@
# DO NOT MODIFY THIS AUTO-GENERATED FILE.
# MODIFYING THIS FILE MAY CAUSE YOUR STACK TO NOT FUNCTION PROPERLY
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really claim this here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true, in the future we will use this UUID for other things too, so want to make sure no one modifies it

@@ -0,0 +1,11 @@
# DO NOT MODIFY THIS AUTO-GENERATED FILE.
# MODIFYING THIS FILE MAY CAUSE YOUR STACK TO NOT FUNCTION PROPERLY
uuid: "{{ uuid }}"
Copy link
Collaborator

@shreyas-goenka shreyas-goenka Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: We could emit all these details as usage logs during template creation. Then we'll only have to persist:

uuid: <>
source_template: mlops-stacks

We could join on uuid during analysis.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that be possible since bundle init doesn't require authentication right? Would we use the unauthenticated usage log endpoint for this? Also, we'd need to still attach UUID to that initial log during template creation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does mlops-stacks use the {{workspace_host}} helper? If so auth is required. It might be required even if you don't use the helper. I'd have to check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the helper (we ask the user to specifically input workspaces that they plan to deploy to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants