Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set data security mode to SINGLE_USER #179

Merged
merged 1 commit into from
Nov 8, 2024
Merged

explicitly set data security mode to SINGLE_USER #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generate-cicd-zip.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
generate-zip:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Generate CICD Zip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
run-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.9
Expand Down
2 changes: 1 addition & 1 deletion template/{{.input_root_dir}}/.github/workflows/deploy-cicd.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
id: timestamp
run: |
echo "timestamp=$(date +'%s')" >> "$GITHUB_ENV"
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: {{`${{ github.event.pull_request.head.sha || github.sha }}`}}
token: {{`${{ secrets.WORKFLOW_TOKEN }}`}}
Expand Down
2 changes: 1 addition & 1 deletion template/{{.input_root_dir}}/.github/workflows/lint-cicd-workflow-files.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Download actionlint
id: get_actionlint
run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
Expand Down
2 changes: 1 addition & 1 deletion ...ate/{{.input_root_dir}}/.github/workflows/{{.input_project_name}}-bundle-cd-prod.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
concurrency: {{ .input_project_name }}-prod-bundle-job
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: databricks/setup-cli@{{template `cli_version` .}}
- name: Validate Bundle For Prod
id: validate
Expand Down
2 changes: 1 addition & 1 deletion .../{{.input_root_dir}}/.github/workflows/{{.input_project_name}}-bundle-cd-staging.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
concurrency: {{ .input_project_name }}-staging-bundle-job
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: databricks/setup-cli@{{template `cli_version` .}}
- name: Validate Bundle For Staging
id: validate
Expand Down
8 changes: 4 additions & 4 deletions template/{{.input_root_dir}}/.github/workflows/{{.input_project_name}}-bundle-ci.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
concurrency: {{ .input_project_name }}-staging-bundle-job
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: {{`${{ github.event.pull_request.head.sha || github.sha }}`}}
- uses: databricks/setup-cli@{{template `cli_version` .}}
Expand All @@ -48,7 +48,7 @@ jobs:
run: |
databricks bundle validate -t {{ .input_staging_catalog_name }} > ../validate_output.txt
- name: Create Comment with Bundle Configuration
uses: actions/github-script@v6
uses: actions/github-script@v7
id: comment
with:
github-token: {{`${{ secrets.GITHUB_TOKEN }}`}}
Expand All @@ -75,7 +75,7 @@ jobs:
concurrency: {{ .input_project_name }}-prod-bundle-job
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: {{`${{ github.event.pull_request.head.sha || github.sha }}`}}
- uses: databricks/setup-cli@{{template `cli_version` .}}
Expand All @@ -92,7 +92,7 @@ jobs:
run: |
databricks bundle validate -t {{ .input_prod_catalog_name }} > ../validate_output.txt
- name: Create Comment with Bundle Configuration
uses: actions/github-script@v6
uses: actions/github-script@v7
id: comment
with:
github-token: {{`${{ secrets.GITHUB_TOKEN }}`}}
Expand Down
4 changes: 2 additions & 2 deletions template/{{.input_root_dir}}/.github/workflows/{{.input_project_name}}-run-tests.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
unit_tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: 3.8
Expand All @@ -50,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4
- uses: databricks/setup-cli@{{template `cli_version` .}}
- name: Validate Bundle For Test Deployment Target in Staging Workspace
id: validate
Expand Down
1 change: 1 addition & 0 deletions ...ct_name_alphanumeric_underscore` .}}/resources/batch-inference-workflow-resource.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ new_cluster: &new_cluster
num_workers: 3
spark_version: 15.3.x-cpu-ml-scala2.12
node_type_id: {{template `cloud_specific_node_type_id` .}}
data_security_mode: "SINGLE_USER"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm these workflows still run on AWS, Azure, and GCP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed this works on dogfood(aws), will test the other in a bit

custom_tags:
clusterSource: mlops-stacks_{{template `stacks_version` .}}

Expand Down
1 change: 1 addition & 0 deletions ...ame_alphanumeric_underscore` .}}/resources/feature-engineering-workflow-resource.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ new_cluster: &new_cluster
num_workers: 3
spark_version: 15.3.x-cpu-ml-scala2.12
node_type_id: {{template `cloud_specific_node_type_id` .}}
data_security_mode: "SINGLE_USER"
custom_tags:
clusterSource: mlops-stacks_{{template `stacks_version` .}}

Expand Down
1 change: 1 addition & 0 deletions ...ate `project_name_alphanumeric_underscore` .}}/resources/model-workflow-resource.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ new_cluster: &new_cluster
num_workers: 3
spark_version: 15.3.x-cpu-ml-scala2.12
node_type_id: {{template `cloud_specific_node_type_id` .}}
data_security_mode: "SINGLE_USER"
custom_tags:
clusterSource: mlops-stacks_{{template `stacks_version` .}}

Expand Down
1 change: 1 addition & 0 deletions ...emplate `project_name_alphanumeric_underscore` .}}/resources/monitoring-resource.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ new_cluster: &new_cluster
num_workers: 3
spark_version: 15.3.x-cpu-ml-scala2.12
node_type_id: {{template `cloud_specific_node_type_id` .}}
data_security_mode: "SINGLE_USER"
custom_tags:
clusterSource: mlops-stacks_{{template `stacks_version` .}}

Expand Down