update docs to remove cookiecutter and add asset bundle templates #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingyu Li <[email protected]>
Signed-off-by: Mingyu Li <[email protected]>
mingyu89
force-pushed
the
use-asset-templates-update-docs
branch
from
1839dc4
to
d0a436f
Compare
arpitjasa-db
approved these changes
Aug 25, 2023
README.md
Outdated
Comment on lines
51
to
52
| * ``input_root_dir``: name of the root directory. The root directory name should be specified if monorepo will be used for the project. | ||
| Otherwise, user can use the name of the current project as root directory name. |
There was a problem hiding this comment.
Leaving it blank is no longer an option? We should make it clearer:
Suggested change
| * ``input_root_dir``: name of the root directory. The root directory name should be specified if monorepo will be used for the project. | |
| Otherwise, user can use the name of the current project as root directory name. | |
| * ``input_root_dir``: name of the root directory. It is recommended to use the name of the current project as the root directory name, except in the case of a monorepo with other projects where the name of the monorepo should be used instead. |
There was a problem hiding this comment.
Yes. Leave it black will use the default value my-mlops-project. Good suggestion.
README.md
Outdated
| @@ -174,12 +173,12 @@ of the example project: | |||
| ``` | |||
| # Note: update MLOPS_STACK_PATH to the path to your local checkout of the stack | |||
| MLOPS_STACK_PATH=~/mlops-stack | |||
| cookiecutter "$MLOPS_STACK_PATH" --config-file "$MLOPS_STACK_PATH/tests/example-project-configs/azure/azure-devops.yaml" --no-input --overwrite-if-exists | |||
| databricks "$MLOPS_STACK_PATH" --config-file "$MLOPS_STACK_PATH/tests/example-project-configs/azure/azure-devops.json" | |||
There was a problem hiding this comment.
just databricks? not databricks bundle?
There was a problem hiding this comment.
Good catch. Should be databricks bundle init
Signed-off-by: Mingyu Li <[email protected]>
mingyu89
added a commit
that referenced
this pull request
Aug 26, 2023
* Fix all mlops stacks tests Signed-off-by: Mingyu Li <[email protected]> * Remove all cookiecutter references from tests Signed-off-by: Mingyu Li <[email protected]> * black . Signed-off-by: Mingyu Li <[email protected]> * Remove cookiecutter parameter file Signed-off-by: Mingyu Li <[email protected]> * Rename more azure_devlops Signed-off-by: Mingyu Li <[email protected]> * Bump version of databricks cli Signed-off-by: Mingyu Li <[email protected]> * update docs to remove cookiecutter and add asset bundle templates (#98) * Update docs Signed-off-by: Mingyu Li <[email protected]> * Add more information about asset templats and link about databricks cli Signed-off-by: Mingyu Li <[email protected]> * Fix doc issues Signed-off-by: Mingyu Li <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]>
mingyu89
added a commit
that referenced
this pull request
Sep 7, 2023
…eation (#96) * WIP Signed-off-by: Mingyu Li <[email protected]> * Complete the implementation and fix all issues Signed-off-by: Mingyu Li <[email protected]> * Skip the test data file when recipe is not used Signed-off-by: Mingyu Li <[email protected]> * Add back support for root dir Signed-off-by: Mingyu Li <[email protected]> * Fix all inconsistency issues based on validation Signed-off-by: Mingyu Li <[email protected]> * Revert changes to stacks docs Signed-off-by: Mingyu Li <[email protected]> * Replace azure_devlops with azure_devops Signed-off-by: Mingyu Li <[email protected]> * Fix all mlops stacks tests (#97) * Fix all mlops stacks tests Signed-off-by: Mingyu Li <[email protected]> * Remove all cookiecutter references from tests Signed-off-by: Mingyu Li <[email protected]> * black . Signed-off-by: Mingyu Li <[email protected]> * Remove cookiecutter parameter file Signed-off-by: Mingyu Li <[email protected]> * Rename more azure_devlops Signed-off-by: Mingyu Li <[email protected]> * Bump version of databricks cli Signed-off-by: Mingyu Li <[email protected]> * update docs to remove cookiecutter and add asset bundle templates (#98) * Update docs Signed-off-by: Mingyu Li <[email protected]> * Add more information about asset templats and link about databricks cli Signed-off-by: Mingyu Li <[email protected]> * Fix doc issues Signed-off-by: Mingyu Li <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]> * Add order to the stacks template schema Signed-off-by: Mingyu Li <[email protected]> * Update cli version to v0.204.0. Throw exception when users try to create project using cookiecutter Signed-off-by: Mingyu Li <[email protected]> * Fix version used by test Signed-off-by: Mingyu Li <[email protected]> * Fix tests by adding a dummy default profile to databricks CLI before generating project Signed-off-by: Mingyu Li <[email protected]> --------- Signed-off-by: Mingyu Li <[email protected]>
|
Having issues installing using the new databricks bundle init |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Update docs.
migration plan https://docs.google.com/document/d/19MOK9o-f0A_-NMmxC1cJGQSQ2WkJXZ4vXQZ4plu-tng/edit