-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dim__orgs.sql #183
base: master
Are you sure you want to change the base?
Update dim__orgs.sql #183
Conversation
b8ff87c
to
e3fa207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ AI Overview
This AI-generated summary of your pull request analyzes your code changes and their potential impact on your data. As this feature is still experimental, please review the details carefully.
-
Major changes to organization identifiers: The modification to
org_id
using modulo operations (org_id % 49
) reduces the total number of organizations from 788 to 541. This has cascading effects on downstream tables, particularly impactingSALES__SYNC
which shows a 45% reduction in records. -
Subscription plan reclassification: The new logic automatically classifies organizations with 1 or fewer users as 'Individual' plans, affecting 200 subscription plan records. Additionally, null prices are now defaulted to 0, which could impact financial calculations and reporting accuracy.
-
Modified user count calculation: The change to
num_users
calculation (count(distinct user_id) + org_id % 2
) affects 263 organizations and has significant downstream impact on financial metrics. Both monthly and yearly financial tables show substantial differences in subscriber counts and revenue calculations.
🕵️ Details
Base branch | Pull Request branch |
master (7334c0f) | snowflake-patch-1 (e3fa207) |
Tables modified: 1 (details)
- Different: 1
DEMO.CORE.DIM__ORGS | ||||||||||||
Primary keys ORG_ID |
||||||||||||
master | snowflake-patch-1 | |||||||||||
DIFFERENCES | ||||||||||||
Total rows | ~788 | ↓ ~541 -31.3% | ||||||||||
Columns with changed type/order: 1
|
||||||||||||
Exclusive PKs | ~257 | ~10 | ||||||||||
4 column(s) with differing values
|
||||||||||||
View details → | ||||||||||||
Unchanged Attributes
|
Downstream tables: 3 (details)
- Different: 3
DEMO.CORE.FCT__YEARLY__FINANCIALS | ||||||||||||
Primary keys DATE_YEAR |
||||||||||||
master | snowflake-patch-1 | |||||||||||
DIFFERENCES | ||||||||||||
Total rows | ~2 | ↓ ~1 -50.0% | ||||||||||
Exclusive PKs | ~1 | ~0 | ||||||||||
2 column(s) with differing values
|
||||||||||||
View details → | ||||||||||||
Unchanged Attributes
|
||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
DEMO.CORE.FCT__MONTHLY__FINANCIALS | ||||||||||||
Primary keys DATE_MONTH |
||||||||||||
master | snowflake-patch-1 | |||||||||||
DIFFERENCES | ||||||||||||
Total rows | ~11 | ↓ ~8 -27.3% | ||||||||||
Exclusive PKs | ~3 | ~0 | ||||||||||
2 column(s) with differing values
|
||||||||||||
View details → | ||||||||||||
Unchanged Attributes
|
||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
DEMO.CORE.SALES__SYNC | ||||||||||||||
Primary keys ORG_ID |
||||||||||||||
master | snowflake-patch-1 | |||||||||||||
DIFFERENCES | ||||||||||||||
Total rows | ~20 | ↓ ~11 -45.0% | ||||||||||||
Exclusive PKs | ~20 | ~11 | ||||||||||||
View details → | ||||||||||||||
Unchanged Attributes
|
||||||||||||||
Modified upstream modelsmodel.demo.dim__orgs |
No description provided.