Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dim__orgs.sql #187

Open
wants to merge 2 commits into
base: master-dremio
Choose a base branch
from
Open

Update dim__orgs.sql #187

wants to merge 2 commits into from

Conversation

diveart
Copy link
Collaborator

@diveart diveart commented Jul 28, 2024

No description provided.

datafold[bot]

This comment was marked as resolved.

@diveart diveart added the Dremio label Jul 28, 2024
datafold[bot]

This comment was marked as resolved.

datafold[bot]

This comment was marked as resolved.

datafold[bot]

This comment was marked as resolved.

Copy link

@datafold datafold bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ AI Overview

This AI-generated summary of your pull request analyzes your code changes and their potential impact on your data. As this feature is still experimental, please review the details carefully.

  • Critical Organization ID Modifications: The changes include a transformation of org_id values using modulo 49, which will subtract 50,000,000 from specific organization IDs. This could significantly impact any downstream joins or filtering based on organization IDs.

  • User Count Calculation Changes: The num_users calculation now includes an additional modifier based on the organization ID (mod(org_id, 2)), which will artificially inflate user counts. This could affect organization size metrics and analytics.

  • Subscription Plan and Price Updates: New logic automatically categorizes organizations with 1 or fewer users as 'Individual' plans, regardless of their actual subscription type. Additionally, null prices will now be converted to 0 using coalesce(price, 0), which could impact revenue calculations.

Was this helpful? Yes / No

🕵️ Details

View CI Run Details →

Base branch Pull Request branch
master-dremio (bd6cdf6) dremio-patch-1 (35fc235)
Tables not found in production schema: 1Please ensure these tables exist and Datafold has access to them.
  • Alexey S3.alexeydremiobucket.prod.dim__orgs
Tables not found in PR schema: 1Please ensure these tables exist and Datafold has access to them.
  • Alexey S3.alexeydremiobucket.PR_NUM_187.dim__orgs
Skipped Data Diffs of downstream tables: 3 Add "datafold:diff-all-downstream" label to this pull request to diff all affected tables
Alexey S3.alexeydremiobucket.prod.sales__sync (table) Run Data Diff →
Alexey S3.alexeydremiobucket.prod.fct__monthly__financials (table) Run Data Diff →
Alexey S3.alexeydremiobucket.prod.fct__yearly__financials (table) Run Data Diff →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant