-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dim__orgs.sql #187
base: master-dremio
Are you sure you want to change the base?
Update dim__orgs.sql #187
Conversation
167bb2e
to
6903832
Compare
6903832
to
35fc235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ AI Overview
This AI-generated summary of your pull request analyzes your code changes and their potential impact on your data. As this feature is still experimental, please review the details carefully.
-
Critical Organization ID Modifications: The changes include a transformation of
org_id
values using modulo 49, which will subtract 50,000,000 from specific organization IDs. This could significantly impact any downstream joins or filtering based on organization IDs. -
User Count Calculation Changes: The
num_users
calculation now includes an additional modifier based on the organization ID (mod(org_id, 2)
), which will artificially inflate user counts. This could affect organization size metrics and analytics. -
Subscription Plan and Price Updates: New logic automatically categorizes organizations with 1 or fewer users as 'Individual' plans, regardless of their actual subscription type. Additionally, null prices will now be converted to 0 using
coalesce(price, 0)
, which could impact revenue calculations.
🕵️ Details
Base branch | Pull Request branch |
master-dremio (bd6cdf6) | dremio-patch-1 (35fc235) |
Tables not found in production schema: 1
Please ensure these tables exist and Datafold has access to them.Alexey S3.alexeydremiobucket.prod.dim__orgs
Tables not found in PR schema: 1
Please ensure these tables exist and Datafold has access to them.Alexey S3.alexeydremiobucket.PR_NUM_187.dim__orgs
Skipped Data Diffs of downstream tables: 3
Add "datafold:diff-all-downstream" label to this pull request to diff all affected tablesAlexey S3.alexeydremiobucket.prod.sales__sync (table) | Run Data Diff → |
Alexey S3.alexeydremiobucket.prod.fct__monthly__financials (table) | Run Data Diff → |
Alexey S3.alexeydremiobucket.prod.fct__yearly__financials (table) | Run Data Diff → |
No description provided.