Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow TableScans of non-federated sources #35

Conversation

phillipleblanc
Copy link
Collaborator

@phillipleblanc phillipleblanc commented May 10, 2024

Relaxes get_table_source called in get_federation_provider to allow TableScans of non-federated tables.

The optimizer already handles this case with:

        // Check if this node determines the FederationProvider
        let sole_provider = self.get_federation_provider(plan)?;
        if sole_provider.is_some() {
            return Ok((None, sole_provider)); // <-- Federated TableScans return Some
        }

        // optimize_inputs
        let inputs = plan.inputs();
        if inputs.is_empty() {
            return Ok((None, None)); // <-- Will mark this TableScan as non-federated by returning None
        }

@backkem backkem merged commit 50fb769 into datafusion-contrib:main May 10, 2024
10 checks passed
@phillipleblanc phillipleblanc deleted the phillip/240510-allow-non-federated-scans-upstream branch May 10, 2024 06:34
phillipleblanc added a commit that referenced this pull request Jan 10, 2025
… (i.e. `SELECT * FROM one.two.three.four.five`) (#35)

* Add MultiPartTableReference

* Capture but don't replace MultiPartTableReferences in the LogicalPlan

* Implement rewrite logic for multi-part tables

* Fix comment

* merging

* Also merge

* Add function support

* Fix doctest running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants