Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible requirements #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Flexible requirements #105

wants to merge 3 commits into from

Conversation

Pierlou
Copy link
Contributor

@Pierlou Pierlou commented Dec 20, 2024

No description provided.

Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the project enough so maybe I miss something, but I don't know about that. For me, requirements.txt is a locked dependencies file, it needs to have the requirements pinned to have a reproducible environment.
This is especially the case here as requirements.txt is used by the CI to build the package, so it needs to be deterministic.
The pyproject.toml file can hold non-pinned dependencies, as it is a project metadata descriptor, but the lock file (requirements.txt or another one like uv.lock or poetry.lock) should always describe the project as precisely and as reproductible as possible.

@bolinocroustibat
Copy link
Contributor

bolinocroustibat commented Dec 21, 2024

@Pierlou
I added in this same PR a commit as a suggestion on how to deal with project vs. pinned dependencies.
This is only an example suggestion!

Sorry I realize now that this definitely should have been a separate PR.
Feel absolutely free to revert the commit if you feel like so, or to ask me to move it to a separate PR!

@bolinocroustibat bolinocroustibat force-pushed the better-requirements branch 4 times, most recently from b8a6694 to d6ef68f Compare December 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants