Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple contact points #263

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Jan 21, 2025

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I couldn't make it work to add a contact point? Did I miss something?

components/ContactPointSelect.vue Outdated Show resolved Hide resolved
components/Dataservices/DescribeDataservice.vue Outdated Show resolved Hide resolved
<ContactPointSelect
v-model="form.contact_point"
v-if="form.contact_points.length === 0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this condition does not work? When adding a contact point a new contact

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition is to handle the case when there is no contact point yet.

When there is one, the template above contains the contact point

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're clear! 🙏

We may want to deploy all related PRs on dev collectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants