Use beta admin as default #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
approved these changes
Jan 10, 2025
maudetes
reviewed
Jan 16, 2025
| @@ -109,6 +109,20 @@ def in_url(*args, **kwargs): | |||
| ) | |||
|
|
|||
|
|
|||
| @front.app_template_global() | |||
| def beta_admin_url_for(path, fallback_path, **kwargs): | |||
There was a problem hiding this comment.
We're missing some routes. They have been documented in datagouv/data.gouv.fr#1648 and can be added in future iterations.
Membership Request notification @
are actually not used. I think udata's templates are used and I guess we can't rely on beta_admin_url_for there. Let's ignore it for now?There was a problem hiding this comment.
I agree, I think we'll have to work on the mailing system at some point because it was not thought with this usecase in mind.
Dataservice is now conditional to having the new admin config
nicolaskempf57
added a commit
to datagouv/front-end
that referenced
this pull request
Feb 5, 2025
Also use non-deprecated function from datagouv/components See datagouv/udata-front#621 on udata-front side Co-authored-by: maudetes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See datagouv/front-end#207 for the same on front-end side