-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql): adds missing containers and browsepathsv2 for dataflow and datajob #12483
Merged
sgomezvillamor
merged 7 commits into
master
from
feature/cus-3452-fix-mssql-dataflow-datajob-containers
Jan 31, 2025
Merged
fix(mssql): adds missing containers and browsepathsv2 for dataflow and datajob #12483
sgomezvillamor
merged 7 commits into
master
from
feature/cus-3452-fix-mssql-dataflow-datajob-containers
Jan 31, 2025
+300
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
... and 1353 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hsheth2
approved these changes
Jan 30, 2025
metadata-ingestion/src/datahub/ingestion/source/sql/mssql/job_models.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/sql/mssql/job_models.py
Outdated
Show resolved
Hide resolved
df3d419
to
43c1c4d
Compare
eagle-25
pushed a commit
to eagle-25/datahub
that referenced
this pull request
Feb 12, 2025
eagle-25
pushed a commit
to eagle-25/datahub
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new attempt that builds on top of PR #12194
Main difference is in previous attempt all dataflow/jobs were at database level, however in the new attemp datajobs representing stored procedures are placed at schema level (as can be seen in second screenshot).
Note
The feature is behind a feature flag, disabled by default until v0.15.0.1 or above are widely adopted.
Testing by ingesting one of the updated golden files:
Checklist