Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring auth in rs #581

Conversation

shreelakshmijoshi
Copy link
Contributor

  • Please refer to the code of conduct : link

  • Please check if the PR fulfills these requirements 📋

  • A new branch is created for the change(s) and the changes are not committed on the main or master branch
  • No credentials or secrets are committed
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, refactor, chore, test, config) 💁 📜
    Refactor, test, config
  • Refactored AuthHandler and JwtAuthenticationServiceImpl to add multiple handlers for authentication and authorization
  • Allowed bearer token to be added in Authorization header for Bearer <JWT-Token> authentication
  • Added helper class RoutingContextHelper to add and fetch objects from routing context
  • Updated and removed some unit tests accordingly

TODO

  • Adding unit tests

  • Updating postman collection to have Bearer

  • Updating example-config

  • Merging DeployerDev to Deployer.java

  • Fixing pmd, checkstyle issues


  • Fixes 🔧 #576

  • Checklist for the current PR 📃

  • I have added the respective changes in the example-config if the changes are made in config
  • For the changes made in example-config, backend components (elasticsearch, flyway files for postgres, immudb schema, rabbitmq) I have notified DX DevOps team by mentioning [at-sign]datakaveri/devops as a PR comment to help facilitate the further necessary changes
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Existing unit tests pass locally with my changes
  • I have added reviewers to check the proposed changes

@jenkins-datakaveri
Copy link
Collaborator

Can one of the admins verify this patch?

@shreelakshmijoshi
Copy link
Contributor Author

retest this please

@shreelakshmijoshi
Copy link
Contributor Author

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants