-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding refactored auth [Not be merged] #582
Open
shreelakshmijoshi
wants to merge
9
commits into
datakaveri:master
Choose a base branch
from
shreelakshmijoshi:adding-refactored-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding refactored auth [Not be merged] #582
shreelakshmijoshi
wants to merge
9
commits into
datakaveri:master
from
shreelakshmijoshi:adding-refactored-auth
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest this please |
Hello, could you please update the configs (config-dev.json and config-test.json) with the audience field according to the environment the resource server is deployed on @datakaveri/devops? example-configs are changed in the PR link
|
@manasakoraganji please update configs in jenkins. |
Update token with Authorization Bearer <JWT> in Rest Assured integration test cases
Hi Shreelakshmi,
I have updated config-dev.json and config-test.json to include the audience
field in the commonConfig. The changes are applied in the pipeline as well
as across all the deployed environments.
Thank you!
…On Mon, 17 Feb 2025 at 13:46, Shreelakshmi Joshi ***@***.***> wrote:
Hello, could you please update the configs (config-dev.json and
config-test.json) with the audience field according to the environment the
resource server is deployed on @datakaveri/devops
<https://github.com/orgs/datakaveri/teams/devops>? example-configs are
changed in the PR link
<https://github.com/datakaveri/dx-resource-server/pull/582/files#diff-bd5b052b909b10c8a09614faabcca4234e605fc9edf139e6be0f4a8bfd5aa943>
"commonConfig": {
"audience": "rs.iudx.io"
},
—
Reply to this email directly, view it on GitHub
<#582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWYO3NMKUOY66W6FZREAXUD2QGLFZAVCNFSM6AAAAABXEU676OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGM2TKNJUHA>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
[image: shreelakshmijoshi]*shreelakshmijoshi* left a comment
(datakaveri/dx-resource-server#582)
<#582 (comment)>
Hello, could you please update the configs (config-dev.json and
config-test.json) with the audience field according to the environment the
resource server is deployed on @datakaveri/devops
<https://github.com/orgs/datakaveri/teams/devops>? example-configs are
changed in the PR link
<https://github.com/datakaveri/dx-resource-server/pull/582/files#diff-bd5b052b909b10c8a09614faabcca4234e605fc9edf139e6be0f4a8bfd5aa943>
"commonConfig": {
"audience": "rs.iudx.io"
},
—
Reply to this email directly, view it on GitHub
<#582 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWYO3NMKUOY66W6FZREAXUD2QGLFZAVCNFSM6AAAAABXEU676OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGM2TKNJUHA>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
--
Manasa Sandhya Koraganji
Associate Software Engineer
Mobile: +91 9381474039
Email: ***@***.***
India Urban Data Exchange
Indian Institute of Science, Bengaluru
Unleashing the Power of Data for Public Good
<https://iudx.org.in/>
<https://www.linkedin.com/company/iudx/> <https://twitter.com/IndiaIudx>
<https://www.facebook.com/India-Urban-Data-Exchange-114855197042929>
<https://www.youtube.com/channel/UCK9oI1VtbKnEe7cJIt_eUFA?view_as=subscriber>
|
Thanks @manasakoraganji , @karun-singh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the code of conduct : link
Please check if the PR fulfills these requirements 📋
Refactor, test, config
Bearer <JWT-Token>
authenticationTODO
Adding unit tests
Updating postman collection to have Bearer
Updating example-config
Merging DeployerDev to Deployer.java
Fixing pmd, checkstyle issues
Fixes 🔧 #576, #316
Checklist for the current PR 📃