Replace response.ok with response.status_code < 400
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .ok is part of the requests API [1], but not part of the httpx API. An equivalent check, according to the requests docs, is to use response.status_code < 400 (In fact, requests' implementation is a try/except around raise_for_status, but this should be the same, although we could use the same pattern instead.) Note that response.status_code < 400 should work with both, requests and httpx, and thus remain backwards compatible. [1]: https://requests.readthedocs.io/en/latest/api/#requests.Response.ok Closes datalad#308.
|
Thanks for opening your first pull request! We are happy to have your contributions 🎉 😄 |
mih
approved these changes
Jul 19, 2024
|
Congrats on merging your first pull request! 😎 The Datalad team is thankful for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .ok is part of the requests API, but not part of the httpx API. An equivalent check, according to the requests docs, is to use response.status_code < 400 (In fact, requests' implementation is a try/except around raise_for_status, but this should be the same, although we could use the same pattern instead.)
Note that response.status_code < 400 should work with both, requests and httpx, and thus remain backwards compatible.
Closes #308.