test: Adjust testremote for expected failure amount #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Dataverse version 5.0, "storeKey when already present" of git-annex testremote will fail, as Dataverse forbade replacing files with identical names and checksums: https://guides.dataverse.org/en/latest/user/dataset-management.html#duplicate-files Because we can't exclude any test from the test suite, but wouldn't want to disable the entire test suite, this change - rather ugly-ly - expects the check to fail, and tests for the right amount of failures in the test suite. Note that it should hopefully be okay to only adjust the tests for this altered behavior of the remote - a checkpresent prior to transfer operations should AFAIK prevent upload/replace attempts of identical files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dataverse version 5.0, "storeKey when already present" of git-annex testremote will fail, as Dataverse forbade replacing files with identical names and checksums:
https://guides.dataverse.org/en/latest/user/dataset-management.html#duplicate-files Because we can't exclude any test from the test suite, but wouldn't want to disable the entire test suite, this change - rather ugly-ly - expects the check to fail, and tests for the right amount of failures in the test suite.
Note that it should hopefully be okay to only adjust the tests for this altered behavior of the remote - a checkpresent prior to transfer operations should AFAIK prevent upload/replace attempts of identical files.
see #320 for explorations.