Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-Documentation Update #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

SDK-Documentation Update #3

wants to merge 11 commits into from

Conversation

4x8Matrix
Copy link
Member

@4x8Matrix 4x8Matrix added the documentation Improvements or additions to documentation label Dec 6, 2022
@4x8Matrix 4x8Matrix requested a review from CompeyDev December 6, 2022 17:02
@4x8Matrix 4x8Matrix self-assigned this Dec 6, 2022
CompeyDev
CompeyDev requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporate the following changes, and then I'll get started on the TypeScript docs.

pages/sdks/sdk/methods/authenticateAsync.mdx Show resolved Hide resolved
pages/sdks/sdk/methods/fireCustomEvent.mdx Outdated Show resolved Hide resolved
pages/sdks/sdk/methods/fireCustomEvent.mdx Outdated Show resolved Hide resolved
CompeyDev
CompeyDev requested changes Dec 7, 2022
View reviewed changes
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the following into account.

pages/sdks/sdk/methods/getPlayerHash.mdx Show resolved Hide resolved
CompeyDev
CompeyDev approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CompeyDev CompeyDev CompeyDev approved these changes

Assignees

@4x8Matrix 4x8Matrix

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4x8Matrix @CompeyDev