-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support bet with any amount. Set min raise to double of previous raise #265
base: dev
Are you sure you want to change the base?
Conversation
@@ -125,7 +125,7 @@ def train(args): | |||
parser.add_argument( | |||
'--cuda', | |||
type=str, | |||
default='', | |||
default='0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make '' as default since some users may not have GPU
# random_agent = RandomAgent(num_actions=env.num_actions) | ||
|
||
env.set_agents([human_agent, human_agent2]) | ||
env.set_agents([human_agent, human_agent2, human_agent3, human_agent4]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We you make it 4 players instead of 2?
@@ -163,6 +163,8 @@ def run(self, is_training=False): | |||
state = self.get_state(player_id) | |||
trajectories[player_id].append(state) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't want to print trajectories in this method, which will affect all the games.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Shld Set this to WIP! WIll resolve the status once the feature is done
@@ -113,7 +113,7 @@ def get_legal_actions(self): | |||
""" | |||
return self.round.get_nolimit_legal_actions(players=self.players) | |||
|
|||
def step(self, action): | |||
def step(self, action_tp): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation of using action_tp? What would the legal actions be with action_tp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action_tp (or action_tuple) [Action, amt: int]
legal actions will only contain FOLD, RAISE, CALL,
In the case of raise, action_tp[1] indicates the amt to raise; In other cases, action_tp[1] is not used
@wgzesg You mentioned, "WIll resolve the status once the feature is done". Just check if this feature is done. Sorry, I lose track of this PR> |
Support bet with any amount. Set min raise to double of previous raise