[WIP] Just to look at diff. #2099

DaveDavenport · 2025-02-19T18:03:05Z

Please follow these steps before submitting your PR:

This PR targets the next branch and not master

If your PR is a work in progress, include [WIP] in its title

Its commits' summaries are reasonably descriptive

You've described what this PR addresses below

You've included links to relevant issues, if any with #issue_num

You've deleted this template

Thank you for contributing to rofi! <3

Your description here...

Based on sardemff7 previous wayland attempt

- Fix mouse support - Handle key repeats - Positioning - Fix periodic count updates

It seems like since meson 0.55.0, subprojects with name separators don't work at all (they were causing a warning before). This is a quick dirty fix, until we fix this upstream. Fixes #2

Overlay is reserved for lock screens and similar programs. Fixes #7

Was causing segfaults when window content updates too fast.

Fixes #9

Fixes #6

See swaywm/wlroots#2422, swaywm/sway#5712

This reverts commit dc1b159. Given the current options, it's probably better to show rofi on top of lock screens than not show it on top of full screen windows. Discussion: #12 #7

Formatting changes only

This was very buggy, we were counting the events twice... * always use pointer frame, it's available since v5 * drop axis handler * use axis_discrete or axis_120 (v >= 8) instead * fail on some protocol minimum version checks * simplify output protocol version check Fixes #120

Happens when destroy() is called without previous init()

And revert erroneous change in historical docs

Only receive clipboard offers when pasting instead of storing the data indefinitely. This is also more performant by default as it is not doing unnecessary work.

> From version 7 onwards, the fd must be mapped with MAP_PRIVATE by the recipient, as MAP_SHARED may fail. - https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_keyboard Signed-off-by: Samuel Dionne-Riel <[email protected]>

Magic values were determined empirically... Fixes #134

config.h needs to be included before ifdef check...

Fixes #81

lbonn · 2025-02-20T17:49:24Z

@DaveDavenport

Big outline:

What I did not want was to just add #ifdef of ifs in every function 😄

xcb.c is renamed to display.c and the two implementations are in xcb/display.c and wayland/display.c. display-internal.h describes the interface they implement and plain display.c just proxies between the two.
the split of view.c is not as clean: generic parts are kept in view.c but everything that was xcb-specific or differed too much from wayland was moved in xcb/view.c and wayland/view.c. The functions which are proxied this way are at the bottom of view.c
there are actually a small number of ifdefs in view.c for some simple cases

For view, ideally wayland/view.c and xcb/view.c should disappear and some of their functionality can be moved to the corresponding display.c and/or another object.
I haven't reviewed exactly what could be put in common recently but I suspect there are at least some low hanging fruits.

Though they sizeable, around 1000 lines for xcb and half for wayland and both display.c are ~2000 lines. So, moving everything there would probably make a mess.

Found with Codacy https://app.codacy.com/gh/davatorium/rofi/pull-requests/2099

lbonn added 30 commits July 24, 2020 19:30

Start moving xcb-specific stuff to their own directory

eb63d83

Move some generic stuff from xcb.h to display.h

90cfdf9

Build wayland protocols via meson

c0b429f

Display something on wayland with layer shell

7d94413

Based on sardemff7 previous wayland attempt

Continue work on wayland mode

97ea1c6

- Fix mouse support - Handle key repeats - Positioning - Fix periodic count updates

Move wayland stuff around

c4bd599

Make xcb and wayland implementations coexist

98a9635

Factorize some view code

183b6b6

Avoid some indirections

8e53896

Put most of view implementation in common

17b4265

wayland: High DPI support

04d2a7a

Avoid calling cleanup when display proxy is NULL

975e715

Add notes about Wayland support in README

a9c0975

Hack for recent versions of meson

498fd2f

It seems like since meson 0.55.0, subprojects with name separators don't work at all (they were causing a warning before). This is a quick dirty fix, until we fix this upstream. Fixes #2

Use TOP layer instead of OVERLAY on Wayland

dc1b159

Overlay is reserved for lock screens and similar programs. Fixes #7

Run indenter

d3e96f2

Merge remote-tracking branch 'upstream/next' into wayland

afe5539

Account for no active view state in various callbacks

33fbefd

Do not crash when no buffer in pool

bd9b5e8

Was causing segfaults when window content updates too fast.

Fix font configuration on wayland

1f828cb

Fixes #9

Fix fullscreen in wayland mode

2e1e362

Fixes #6

Merge remote-tracking branch 'upstream/next' into wayland

f013971

Merge remote-tracking branch 'upstream/next' into wayland

cef94af

wayland: set anchors on both size when auto-sizing

74a157c

See swaywm/wlroots#2422, swaywm/sway#5712

Merge remote-tracking branch 'upstream/next' into wayland

807a2c0

Revert "Use TOP layer instead of OVERLAY on Wayland"

87b48ce

This reverts commit dc1b159. Given the current options, it's probably better to show rofi on top of lock screens than not show it on top of full screen windows. Discussion: #12 #7

Run indenter

7d4c5e8

Merge tag '1.6.1' into wayland

ab1ce4a

Merge commit '1a1dc7282f5ed010af874398b5b3d70ea7cda8e8' into wayland

deb9330

Merge commit '954fc728b29d3c63a09a84870f29b57640062966' into wayland

6baa463

Formatting changes only

lbonn and others added 28 commits March 1, 2024 11:27

[WaylandWindow] Remove a scary log

ccea312

Happens when destroy() is called without previous init()

[Doc] Fix -global-kb docs

be7c088

And revert erroneous change in historical docs

Bump to 1.7.5+wayland3

32d229b

Set -dev version

1c41373

[Wayland] Handle clipboard pasting more securely

d8ba203

Only receive clipboard offers when pasting instead of storing the data indefinitely. This is also more performant by default as it is not doing unnecessary work.

[Wayland] Fix CodeQL overflow warning

47ae31e

Update documentation with the new rofi-wayland Arch package

812ad02

Merge remote-tracking branch 'upstream/next' into wayland

51dec9d

wayland/display: Fix mmap use

b04bedc

> From version 7 onwards, the fd must be mapped with MAP_PRIVATE by the recipient, as MAP_SHARED may fail. - https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_keyboard Signed-off-by: Samuel Dionne-Riel <[email protected]>

[Wayland] Fix touchpad scrolling

93ad86d

Magic values were determined empirically... Fixes #134

[Wayland] Add missing methods in wl_data_device_listener

d88b475

Update rofi-sensible-terminal to include foot

142e780

Merge remote-tracking branch 'upstream/next' into wayland

2baa809

Remove duplicated disable history code

0a0cc5f

Fixing incorrect link in INSTALL.md

0abd887

Merge tag '1.7.7' into wayland

57c53bd

Fix a shadowing warning

fab7901

Fix imdkit detection

3550af6

config.h needs to be included before ifdef check...

Rofi 1.7.7+wayland1

96df6d2

Set -dev version

5cf3d34

Merge remote-tracking branch 'upstream/next' into wayland

5df2d3a

Merge tag '1.7.8' into wayland

42c384a

Add tag in gh artifacts names

e22d8ff

Rofi 1.7.8+wayland1

3698186

Review files exported in tarballs

03a3a58

Merge remote-tracking branch 'upstream/next' into wayland

cebb0fd

Wayland: fix key repeat rate

183b0b5

Fixes #81

Wayland: remove some dead code

3bec3fa

Found with Codacy https://app.codacy.com/gh/davatorium/rofi/pull-requests/2099

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Just to look at diff. #2099

[WIP] Just to look at diff. #2099

DaveDavenport commented Feb 19, 2025

lbonn commented Feb 20, 2025

[WIP] Just to look at diff. #2099

Are you sure you want to change the base?

[WIP] Just to look at diff. #2099

Conversation

DaveDavenport commented Feb 19, 2025

lbonn commented Feb 20, 2025