Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicate code #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean up duplicate code #1

wants to merge 1 commit into from

Conversation

davhdavh
Copy link
Owner

@davhdavh davhdavh commented Mar 15, 2021

Resolves dotnet#30928.
It could technically remove the null check since the current js API also does a null check and thus doesnt care if called with no parameter or null parameter, but preserved to maintain API.

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Summary of the changes (Less than 80 chars)

PR Description
Detail 1
Detail 2

Addresses #bugnumber (in this specific format)

Sorry, something went wrong.

Resolves dotnet#30928.
It could technically remove the null check since the current js API also does a null check and thus doesnt care if called with no parameter or null parameter, but preserved to maintain API.
@javiercn
Copy link

@davhdavh thanks for submitting a PR.

Unfortunately this is a breaking change and not something we want accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate code in RemoteAuthenticationService
2 participants