Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option for estimating number of pages #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bkepps
Copy link

@bkepps bkepps commented Aug 4, 2020

This adds two more options to the page count settings

  • estimate pages by lines of words (value stored in pagesbylines)
  • a textfield to enter the number of lines in each page (value stored in linesperpage)

when pagesbylines is true, wordsperpage is ignored and linesperpage is used to calculate the number of pages, and vice versa

The number of lines is kept track of at the bottom of src/lua/redraw.lua by totaling the number of lines returned by wrap() for each paragraph. This is then stored in Document.linecount.

@bkepps
Copy link
Author

bkepps commented Dec 4, 2020

Do I need to close this pull request myself? I saw that you closed the related issue a while back, but not this pull request. I'm new to contributing to open source, so I don't really know how these things work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant