refactor(meta): use ngx-meta lib #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
davidlj95
force-pushed
the
stacked/feat-seo-add-seo-services
branch
from
acdc61a to
779409d
Compare
davidlj95
changed the title
davidlj95
force-pushed
the
stacked/feat-seo-add-seo-services
branch
from
c043714 to
6bae759
Compare
davidlj95
commented
Nov 22, 2023
davidlj95
force-pushed
the
stacked/feat-seo-add-seo-services
branch
from
3bdbd77 to
1e2803a
Compare
davidlj95
changed the title
davidlj95
force-pushed
the
stacked/feat-seo-add-seo-services
branch
from
1e2803a to
13fe428
Compare
davidlj95
commented
Dec 17, 2023
Comment on lines
-1
to
-6
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="JavaScriptLibraryMappings"> | ||
| <file url="PROJECT" libraries="{decap-cms}" /> | ||
| </component> | ||
| </project> |
There was a problem hiding this comment.
No idea why this disappeared but I think it's not needed in first place
There was a problem hiding this comment.
It appeared when introducing Decap CMS in it's index.html but we barely touch that file so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses freshly baked
@davidlj95/ngx-metapackage to set metadata. Instead of@ngaox/seoThe library has peer dependencies updated :) And tests to ensure it works across several Angular versions. Including new one (v17)