-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NetBSD as a supported platform, use case for PLATFORM test #434
base: master
Are you sure you want to change the base?
Conversation
Hi. Thanks a lot. Can you confirm that dinit works when building it with |
It builds and works with CPPFLAGS="-DDASYNQ_HAVE_KQUEUE=1", I booted a virtual machine with it. Would you suggest to build with this defined as default? |
Probably, Based on https://man.netbsd.org/kqueue.2#HISTORY. Also it would be great if you send a patch (after testing) to https://github.com/davmac314/dasynq and change the default "if" (https://github.com/davmac314/dasynq/blob/7cf74df6b758fa11876d26b5173c382a976a7917/include/dasynq/config.h#L56) to include NetBSD. |
Co-authored-by: Mobin <[email protected]>
NetBSD patch submitted for dasynq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the mentioned thing, This PR is
Reviewed-by: Mobin Aydinfar <[email protected]>
Co-authored-by: Mobin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Mobin Aydinfar <[email protected]>
I tested dinit on NetBSD as far as replacing /sbin/init with it and it works! FYI I packaged it for pkgsrc in sysutils/dinit