Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NetBSD as a supported platform, use case for PLATFORM test #434

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iMilnb
Copy link

@iMilnb iMilnb commented Jan 28, 2025

I tested dinit on NetBSD as far as replacing /sbin/init with it and it works! FYI I packaged it for pkgsrc in sysutils/dinit

@mobin-2008 mobin-2008 added Enhancement/New Feature Improving things or introduce new feature P-BSD Things related to BSD A-Importance: Normal C-dinit Things about the main parts of dinit C-shutdown Things about shutdown/reboot/halt utilities labels Jan 29, 2025
@mobin-2008
Copy link
Collaborator

Hi. Thanks a lot. Can you confirm that dinit works when building it with ./configure CPPFLAGS="-DDASYNQ_HAVE_KQUEUE=1"?

@iMilnb
Copy link
Author

iMilnb commented Jan 29, 2025

It builds and works with CPPFLAGS="-DDASYNQ_HAVE_KQUEUE=1", I booted a virtual machine with it. Would you suggest to build with this defined as default?
If you're interested, my NetBSD-dinit system is here: https://github.com/NetBSDfr/smolBSD/tree/main/service/systembsd

@mobin-2008
Copy link
Collaborator

mobin-2008 commented Jan 29, 2025

It builds and works with CPPFLAGS="-DDASYNQ_HAVE_KQUEUE=1", I booted a virtual machine with it. Would you suggest to build with this defined as default?

Probably, Based on https://man.netbsd.org/kqueue.2#HISTORY.

Also it would be great if you send a patch (after testing) to https://github.com/davmac314/dasynq and change the default "if" (https://github.com/davmac314/dasynq/blob/7cf74df6b758fa11876d26b5173c382a976a7917/include/dasynq/config.h#L56) to include NetBSD.

configure Outdated Show resolved Hide resolved
Co-authored-by: Mobin <[email protected]>
@iMilnb
Copy link
Author

iMilnb commented Jan 29, 2025

Also it would be great if you send a patch (after testing) to https://github.com/davmac314/dasynq and change the default "if" (https://github.com/davmac314/dasynq/blob/7cf74df6b758fa11876d26b5173c382a976a7917/include/dasynq/config.h#L56) to include NetBSD.

NetBSD patch submitted for dasynq

configure Outdated Show resolved Hide resolved
mobin-2008
mobin-2008 previously approved these changes Jan 29, 2025
Copy link
Collaborator

@mobin-2008 mobin-2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the mentioned thing, This PR is

Reviewed-by: Mobin Aydinfar <[email protected]>

@mobin-2008 mobin-2008 requested a review from davmac314 January 29, 2025 16:44
Co-authored-by: Mobin <[email protected]>
Copy link
Collaborator

@mobin-2008 mobin-2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Mobin Aydinfar <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Normal C-dinit Things about the main parts of dinit C-shutdown Things about shutdown/reboot/halt utilities Enhancement/New Feature Improving things or introduce new feature P-BSD Things related to BSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants