cleanup #20
cleanup #20
Conversation
marfoldi
commented
Sep 25, 2023
•
marfoldi
commented
- Some cleanup in "src/utils/normalize-request.ts"
- Add dependabot
- Add linter
- Publish to GitHub packages
| cf: { | ||
| // NOTE: cf is Enterprise only feature |
There was a problem hiding this comment.
@samkahchiin I did not find in the documentation that this would be an enterprise-only feature, maybe it is publicly available now?
| response = new Response(response.body, response); | ||
| response.headers.set('edge-cache-ttl', `${edgeCacheTtl}`) | ||
| if (edgeCacheTtl > 0) { // Only set the header if edgeCacheTtl is set | ||
| response.headers.set('edge-cache-ttl', `${edgeCacheTtl}`); |
There was a problem hiding this comment.
Do we want to set this to 0 if not defined?
There was a problem hiding this comment.
The whole point of such a repo is to have sane defaults for all projects, i.e. ideally, we can always use this project without any options set at all, because we have great defaults for everything.
What would be a great default for caching?
There was a problem hiding this comment.
You're right, I'm just wondering whether it wouldn't be unexpected that everything is getting cached let's say for a day. It would definitely be needed to add CircleCi --> Purge Cloudflare cache on deploy for every project as well.
There was a problem hiding this comment.
agreed. Purging the cache after deploy should be in the standardized CircleCi config file :)
| accountId?: string | ||
| zoneId?: string |
There was a problem hiding this comment.
These are unused, leaving them here as optional properties, one might find it helpful to identify deployments in their worker code....
| response = new Response(response.body, response); | ||
| response.headers.set('edge-cache-ttl', `${edgeCacheTtl}`) | ||
| if (edgeCacheTtl > 0) { // Only set the header if edgeCacheTtl is set | ||
| response.headers.set('edge-cache-ttl', `${edgeCacheTtl}`); |
There was a problem hiding this comment.
The whole point of such a repo is to have sane defaults for all projects, i.e. ideally, we can always use this project without any options set at all, because we have great defaults for everything.
What would be a great default for caching?
