Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack/ecr-scanner-notifier: Add ECR scanner Slack notifier #196

Merged
merged 32 commits into from
Nov 27, 2023

Conversation

samkahchiin
Copy link
Contributor

@samkahchiin samkahchiin commented Apr 11, 2023

Summary

Send slack message when a vulnerability is found in the ECR image scanning

Motivation

closes #171

@swiknaba swiknaba added wip Work in progress. Do not merge. and removed wip Work in progress. Do not merge. labels May 15, 2023
Copy link
Contributor

@swiknaba swiknaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Using a Lambda seems to be a good choice. Any chance you'll have time to finish this? Low prior I think. Also: why add python (yet another tool) to our stack?

@samkahchiin samkahchiin marked this pull request as ready for review November 24, 2023 12:16
@samkahchiin samkahchiin requested a review from a team as a code owner November 24, 2023 12:16
@samkahchiin samkahchiin assigned swiknaba and unassigned samkahchiin Nov 24, 2023
swiknaba
swiknaba previously approved these changes Nov 24, 2023
Copy link
Contributor

@swiknaba swiknaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, but if you have, time please ensure:

  • the documentation in the README is not different from the default value in the variables file to avoid confusion
  • never use [], unless a nil return value is a tested code path to reduce the number of possible bugs

I've also left a few NITs that help make the code more readable.

slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
lambda/README.md Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Outdated Show resolved Hide resolved
slack/ecr-scanner-notifier/script/main.rb Show resolved Hide resolved
slack/ecr-scanner-notifier/variables.tf Outdated Show resolved Hide resolved
stack/global/variables.tf Show resolved Hide resolved
@dblworks dblworks assigned samkahchiin and unassigned swiknaba Nov 24, 2023
@samkahchiin samkahchiin assigned swiknaba and unassigned samkahchiin Nov 27, 2023
swiknaba
swiknaba previously approved these changes Nov 27, 2023
Copy link
Contributor

@swiknaba swiknaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature, thank you!

Copy link
Contributor

@swiknaba swiknaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the name of the lambda output :)

@samkahchiin samkahchiin merged commit 543fe5c into main Nov 27, 2023
115 checks passed
@samkahchiin samkahchiin deleted the sam-add-ecr-scanner-slack-notifier branch November 27, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send slack message when a vulnerability is found in the ECR image scanning
2 participants