-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slack/ecr-scanner-notifier: Add ECR scanner Slack notifier #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea. Using a Lambda seems to be a good choice. Any chance you'll have time to finish this? Low prior I think. Also: why add python (yet another tool) to our stack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, but if you have, time please ensure:
- the documentation in the README is not different from the default value in the variables file to avoid confusion
- never use
[]
, unless anil
return value is a tested code path to reduce the number of possible bugs
I've also left a few NITs that help make the code more readable.
Co-authored-by: Lud <[email protected]>
Co-authored-by: Lud <[email protected]>
Co-authored-by: Lud <[email protected]>
Co-authored-by: Lud <[email protected]>
Co-authored-by: Lud <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome feature, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the name of the lambda output :)
Summary
Send slack message when a vulnerability is found in the ECR image scanning
Motivation
closes #171