Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (other-stuff): New action to quickly upload images to imgur #1059

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

nay-cat
Copy link
Contributor

@nay-cat nay-cat commented Dec 16, 2024

Added quick action to upload image to Imgur, with support to Imgur 2, using the package

I know it could be done through the API, but this method is faster and more versatile, you give it a URL and it returns the URL uploaded to Imgur, with only two parameters.

Copy link
Contributor

@OneAndOnlyFinbar OneAndOnlyFinbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint (npm run lint:fix && npm run prettier:fix in console) then its good.

@nay-cat
Copy link
Contributor Author

nay-cat commented Dec 17, 2024

Done (i think)

@nay-cat
Copy link
Contributor Author

nay-cat commented Dec 17, 2024

I have tested it and it seems to work with the changes

image

@OneAndOnlyFinbar
Copy link
Contributor

Lint still failing

@nay-cat
Copy link
Contributor Author

nay-cat commented Dec 17, 2024

image
I don't understand why it doesn't work, maybe it's because of copying it manually and uploading it instead of using the terminal?

@OneAndOnlyFinbar
Copy link
Contributor

For no-unused-vars error it shows you the line and column its at (line:col on the left). Just remove the variables on the lines and lint should pass.

@OneAndOnlyFinbar OneAndOnlyFinbar merged commit 53eeb77 into dbm-network:master Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants