Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent errors due to non-conforming tvdb api response #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mueslo
Copy link

@mueslo mueslo commented Jun 6, 2020

fixes #73 / #85

@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #81 into master will decrease coverage by 0.49%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   82.42%   81.92%   -0.50%     
==========================================
  Files           1        1              
  Lines         495      498       +3     
==========================================
  Hits          408      408              
- Misses         87       90       +3     
Impacted Files Coverage Δ
tvdb_api.py 81.92% <50.00%> (-0.50%) ⬇️

@dbr
Copy link
Owner

dbr commented Jun 15, 2020

Thanks for this! I'll look at merging this in as soon as I can - I may implement it slightly differently, I'd rather a more specific check than catching tvdb_error as there could potentially be legitimate problems retrieving the actors info which shouldn't be suppressed

@mueslo
Copy link
Author

mueslo commented Aug 13, 2020

Any update? This is still a critical issue 😢

Back when I wrote this I also reported it to TheTVDB where it was supposedly ticketed to be fixed, but so far nothing has changed. Instead, they seem to be focusing on yet another major non-backwards-compatible API release...

@mueslo
Copy link
Author

mueslo commented Oct 16, 2020

I opened a ticket after not receiving a response on https://forums.thetvdb.com/viewtopic.php?f=41&t=65534 and it will NOT be fixed (only in their next version of the API). So it is critical to have a workaround...

@mueslo mueslo force-pushed the patch-1 branch 4 times, most recently from 22048ac to 63f4223 Compare October 16, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API returns unexpected None for actors
2 participants