Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wavpack.c #89

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Update wavpack.c #89

merged 1 commit into from
Dec 22, 2020

Conversation

ihsinme
Copy link
Contributor

@ihsinme ihsinme commented Dec 22, 2020

I apologize for this mistake.

@ihsinme
Update wavpack.c
7355ea4 
I apologize for this mistake.
@ihsinme ihsinme mentioned this pull request Dec 22, 2020
Merged
@dbry
Copy link
Owner

dbry commented Dec 22, 2020

I'm actually a little surprised this happened. I guess I shouldn't assume that when someone posts a PR they have actually built and tested the change.

Have you actually built it this time?

@ihsinme
Copy link
Contributor Author

ihsinme commented Dec 22, 2020

you are absolutely right.
I apologize again.
the error occurred because I added similar changes manually at your request.
the current PR is fully functional and tested by me.
I also ask you to pay attention to #90 it will exclude such situations in the future

@ihsinme
Copy link
Contributor Author

ihsinme commented Dec 22, 2020

this PR needs to be accepted so that your project is going to be assembled without errors.

@dbry dbry merged commit 940a8b7 into dbry:master Dec 22, 2020
@ihsinme ihsinme deleted the patch-3 branch December 23, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihsinme @dbry