Flexible delete+insert incremental strategy that purely relies on incremental_predicates #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to perform fine-grained optimizations that does not rely on the unique key. This optimization is important for data warehouses like Redshift, where there is no concept of primary/unique keys and indexes.
resolves dbt-labs/dbt-core#10655
Problem
Full description of the problem can be found here
Solution
This PR makes the
incremental_predicates
mandatory if nounique_key
. was supplied. Below is an example config:The
DBT_INTERNAL_DEST
andDBT_INTERNAL_SOURCE
are translated to their equivalent table names using a simple string replace. This change affects the generated delete statement. Here is an example:This change no longer allows the
delete+insert
strategy to be used as if it were anappend
strategy by omitting theunique_key
.Checklist