-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add src
directory structure for dbt-adapters
#357
Draft
mikealfare
wants to merge
10
commits into
main
Choose a base branch
from
monorepo-dbt-adapters-src-subpackage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the package readmes
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
mikealfare
changed the title
Add src directory structure for
Add Nov 16, 2024
dbt-adapters
src
directory structure for dbt-adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving to a monorepo, we have decided to adopt the
src
namespace approach for storing functional code. Additionally, we will movedbt-adapters
to be a package subdirectory, just like any other package in this repo. This will allow us to have a place for shared assets, resources, docs, etc. that are not specific to any particular package.While updating
pyproject.toml
with these changes, I noticed that we use__about__.py
to store the package version. However, other packages use__version__.py
, and we are locked into this because this version is read by other packages. We should updatedbt-tests-adapter
to use__version__.py
to standardize.