Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src directory structure for dbt-adapters #357

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Nov 16, 2024

As part of moving to a monorepo, we have decided to adopt the src namespace approach for storing functional code. Additionally, we will move dbt-adapters to be a package subdirectory, just like any other package in this repo. This will allow us to have a place for shared assets, resources, docs, etc. that are not specific to any particular package.

While updating pyproject.toml with these changes, I noticed that we use __about__.py to store the package version. However, other packages use __version__.py, and we are locked into this because this version is read by other packages. We should update dbt-tests-adapter to use __version__.py to standardize.

@mikealfare mikealfare self-assigned this Nov 16, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 16, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare changed the title Add src directory structure for dbt-adapters Add src directory structure for dbt-adapters Nov 16, 2024
@mikealfare mikealfare marked this pull request as ready for review November 16, 2024 23:20
@mikealfare mikealfare requested a review from a team as a code owner November 16, 2024 23:20
@mikealfare mikealfare marked this pull request as draft November 17, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant