Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: server address key "guid=" is lost #192

Open
jokeyrhyme opened this issue Jan 15, 2025 · 0 comments · May be fixed by #198
Open

regression: server address key "guid=" is lost #192

jokeyrhyme opened this issue Jan 15, 2025 · 0 comments · May be fixed by #198
Labels
bug Something isn't working

Comments

@jokeyrhyme
Copy link
Contributor

@zeenix zeenix added the bug Something isn't working label Jan 15, 2025
jokeyrhyme added a commit to jokeyrhyme/busd that referenced this issue Jan 27, 2025
@jokeyrhyme
🐛 Include address key (guid) in address again
7538d07 
We previously had a mutable variable, and assigned to this variable from
deep within multiple `match`es, which was easy for me to overlook.

This new approach drops the `let mut` in favour of multiple immutable
variables, which we assign to at the top-level of the function (not
deeply-indented), which makes it easier to notice.

Finally, when we assign the new `Address` for use with UNIX sockets,
we also add the address key (guid) which had accidentally been dropped.

fixes dbus2#192
jokeyrhyme added a commit to jokeyrhyme/busd that referenced this issue Jan 27, 2025
@jokeyrhyme
🐛 Add previous guid to new address
29afa5e 
fixes dbus2#192
@jokeyrhyme jokeyrhyme linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Add previous guid to new address jokeyrhyme/busd
2 participants
@zeenix @jokeyrhyme