Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add previous guid to new address #198

Merged
merged 1 commit into from
Feb 1, 2025
Merged

🐛 Add previous guid to new address #198

merged 1 commit into from
Feb 1, 2025

Conversation

jokeyrhyme
Copy link
Contributor

@jokeyrhyme jokeyrhyme commented Jan 27, 2025 •
edited
Loading

We re-add the previous guid value to the new address.

fixes #192

zeenix
zeenix requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be super simple by just dropping the first commit. address (or any other variables can be turned mutable as a minor detail as part of the commit.

@jokeyrhyme jokeyrhyme force-pushed the 192-bring-back-address-key-guid branch from 29afa5e to 895d324 Compare February 1, 2025 03:54
@jokeyrhyme
Copy link
Contributor Author

Okay, I've removed the refactor commit and re-tested against zbus

@zeenix zeenix merged commit 4dd15a7 into dbus2:main Feb 1, 2025
8 checks passed
@jokeyrhyme jokeyrhyme deleted the 192-bring-back-address-key-guid branch February 1, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeenix zeenix zeenix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: server address key "guid=" is lost
2 participants
@jokeyrhyme @zeenix