Newbie mistakes were made. Fix postgres service

Dockerfile

@@ -25,17 +25,14 @@ RUN apt-get update \
 RUN pip install --upgrade pip virtualenv
 
 # setup postgresql database and user.
+# We don't expose the port, but allow all incomming connections
 USER postgres
-RUN echo "host all  all    0.0.0.0/0  md5" >> /etc/postgresql/11/main/pg_hba.conf
-RUN echo "listen_addresses='*'" >> /etc/postgresql/11/main/postgresql.conf
-RUN service postgresql restart 
-RUN psql -c "CREATE USER ctest WITH SUPERUSER PASSWORD 'coveragetest123';ALTER USER ctest CREATEDB;"
-RUN createdb -O ctest demo
+# configure the user for later. the service will be started in the entrypoint
+RUN  service postgresql start \
+&& psql -c "CREATE USER ctest WITH SUPERUSER PASSWORD 'coveragetest123';ALTER USER ctest CREATEDB;"
 USER root
 
 
-EXPOSE 5432
-
 COPY entrypoint.sh /
 RUN chmod +x /entrypoint.sh
 ENTRYPOINT ["/entrypoint.sh"]

entrypoint.sh

@@ -8,6 +8,10 @@ echo "Starting ${GITHUB_WORKFLOW}:${GITHUB_ACTION}"
 APP=$1
 MIN_COVERAGE=$2
 
+# start PostgreSQL
+service postgresql start
+
+# setup run settings
 if [ -z "${APP}" ]; then
     # coverage on everything when app is empty
     APP_LOCATION="."
@@ -17,6 +21,7 @@ else
     VENV_NAME=virtenv_$APP
 fi
 
+# init virtual environment
 if ! [ -e "${GITHUB_WORKSPACE}/${VENV_NAME}" ]; then
     python3 -m venv "${GITHUB_WORKSPACE}/${VENV_NAME}"
 fi
@@ -25,8 +30,9 @@ source "${GITHUB_WORKSPACE}/${VENV_NAME}/bin/activate"
 
 pip install -r requirements.txt
 
+echo "Base setup complete. Setting up a sample DB url and running..."
 export DATABASE_URL='postgresql://ctest:[email protected]:5432/demo'
-echo "Base setup complete. Setting up a sample DB url"
+
 # This will automatically fail (set -e is set by default) if the tests fail, which is OK.
 coverage run --source "${APP_LOCATION}" manage.py test "${APP}"