Fix clippy warnings

deadlinks · Nov 27, 2022 · de40613 · de40613
1 parent 2fb1be6
commit de40613
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/src/bin/cargo-deadlinks.rs b/src/bin/cargo-deadlinks.rs
@@ -199,8 +199,7 @@ fn determine_dir(
             .packages
             .into_iter()
             .filter(|package| package.source.is_none())
-            .map(|package| package.targets)
-            .flatten()
+            .flat_map(|package| package.targets)
             .filter(has_docs)
             .map(move |target| doc.join(target.name.replace('-', "_")));
         return iter.collect();
@@ -214,6 +213,7 @@ fn determine_dir(
     });
     // Stolen from https://docs.rs/cargo_metadata/0.12.0/cargo_metadata/#examples
     let mut cargo_process = Command::new(cargo);
+    #[allow(clippy::needless_borrow)] // MSRV is 1.46
     cargo_process
         .args(&[
             "doc",

diff --git a/src/lib.rs b/src/lib.rs
@@ -1,4 +1,5 @@
-//! <https://tinyurl.com/rnxcavf>
+#![allow(clippy::result_large_err)]
+
 use std::{
     fmt,
     path::{Path, PathBuf},
@@ -95,7 +96,7 @@ impl FileError {
     fn shorten_all(&mut self, prefix: &Path) {
         use check::Link;
 
-        if let Ok(shortened) = self.path.strip_prefix(&prefix) {
+        if let Ok(shortened) = self.path.strip_prefix(prefix) {
             self.path = shortened.to_path_buf();
         };
         for mut e in &mut self.errors {

diff --git a/tests/non_existent_http_link.rs b/tests/non_existent_http_link.rs
@@ -38,7 +38,7 @@ mod non_existent_http_link {
         // fails with --check-http flag
         Command::cargo_bin("cargo-deadlinks")
             .unwrap()
-            .args(&["deadlinks", "--check-http"])
+            .args(["deadlinks", "--check-http"])
             .current_dir("./tests/non_existent_http_link")
             .assert()
             .failure()

diff --git a/tests/working_http_check.rs b/tests/working_http_check.rs
@@ -9,7 +9,7 @@ mod working_http_check {
     use super::*;
 
     fn remove_target(relative_path: &'static str) {
-        match std::fs::remove_dir_all(&format!("./tests/working_http_check/{}", relative_path)) {
+        match std::fs::remove_dir_all(format!("./tests/working_http_check/{}", relative_path)) {
             Ok(_) => {}
             Err(err) => match err.kind() {
                 std::io::ErrorKind::NotFound => {}
@@ -34,7 +34,7 @@ mod working_http_check {
         // succeeds with --check-http flag
         Command::cargo_bin("cargo-deadlinks")
             .unwrap()
-            .args(&["deadlinks", "--check-http"])
+            .args(["deadlinks", "--check-http"])
             .current_dir("./tests/working_http_check")
             .assert()
             .success();
@@ -45,7 +45,7 @@ mod working_http_check {
         remove_target("target2");
         Command::cargo_bin("cargo-deadlinks")
             .unwrap()
-            .args(&[
+            .args([
                 "deadlinks",
                 "--forbid-http",
                 "--",