Skip to content

Commit

Permalink
[FIX] 테이블 정보가 업데이트 되지 않는 문제 해결 (#79)
Browse files Browse the repository at this point in the history
  • Loading branch information
@coli-geonwoo
coli-geonwoo authored Jan 28, 2025
1 parent 4ed1f2b commit a83f68e
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 38 deletions.
2 changes: 1 addition & 1 deletion src/main/java/com/debatetimer/repository/parliamentary/ParliamentaryTimeBoxRepository.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ default ParliamentaryTimeBoxes findTableTimeBoxes(ParliamentaryTable table) {
}

@Query("DELETE FROM ParliamentaryTimeBox ptb WHERE ptb IN :timeBoxes")
@Modifying(clearAutomatically = true)
@Modifying(clearAutomatically = true, flushAutomatically = true)
@Transactional
void deleteAll(List<ParliamentaryTimeBox> timeBoxes);
}
16 changes: 7 additions & 9 deletions src/test/java/com/debatetimer/controller/parliamentary/ParliamentaryControllerTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,12 @@ class UpdateTable {
void 의회식_토론_테이블을_업데이트한다() {
Member bito = memberGenerator.generate("비토");
ParliamentaryTable bitoTable = tableGenerator.generate(bito);
TableInfoCreateRequest renewTableInfo = new TableInfoCreateRequest("비토 테이블", "주제");
List<TimeBoxCreateRequest> renewTimeBoxes = List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
);
ParliamentaryTableCreateRequest renewTableRequest = new ParliamentaryTableCreateRequest(
renewTableInfo,
renewTimeBoxes
new TableInfoCreateRequest("비토 테이블", "주제"),
List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
)
);

ParliamentaryTableResponse response = given()
Expand All @@ -101,8 +99,8 @@ class UpdateTable {

assertAll(
() -> assertThat(response.id()).isEqualTo(bitoTable.getId()),
() -> assertThat(response.info().name()).isEqualTo(renewTableInfo.name()),
() -> assertThat(response.table()).hasSize(renewTimeBoxes.size())
() -> assertThat(response.info().name()).isEqualTo(renewTableRequest.info().name()),
() -> assertThat(response.table()).hasSize(renewTableRequest.table().size())
);
}
}
Expand Down
53 changes: 25 additions & 28 deletions src/test/java/com/debatetimer/service/parliamentary/ParliamentaryServiceTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,21 @@ class Save {
@Test
void 의회식_토론_테이블을_생성한다() {
Member chan = memberGenerator.generate("커찬");
TableInfoCreateRequest requestTableInfo = new TableInfoCreateRequest("커찬의 테이블", "주제");
List<TimeBoxCreateRequest> requestTimeBoxes = List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
);
ParliamentaryTableCreateRequest chanTableRequest = new ParliamentaryTableCreateRequest(
requestTableInfo,
requestTimeBoxes
new TableInfoCreateRequest("커찬의 테이블", "주제"),
List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
)
);

ParliamentaryTableResponse savedTableResponse = parliamentaryService.save(chanTableRequest, chan);
Optional<ParliamentaryTable> foundTable = parliamentaryTableRepository.findById(savedTableResponse.id());
List<ParliamentaryTimeBox> foundTimeBoxes = timeBoxRepository.findAllByParliamentaryTable(foundTable.get());

assertAll(
() -> assertThat(foundTable.get().getName()).isEqualTo(requestTableInfo.name()),
() -> assertThat(foundTimeBoxes).hasSize(requestTimeBoxes.size())
() -> assertThat(foundTable.get().getName()).isEqualTo(chanTableRequest.info().name()),
() -> assertThat(foundTimeBoxes).hasSize(chanTableRequest.table().size())
);
}
}
Expand Down Expand Up @@ -92,23 +90,24 @@ class UpdateTable {
void 의회식_토론_테이블을_수정한다() {
Member chan = memberGenerator.generate("커찬");
ParliamentaryTable chanTable = tableGenerator.generate(chan);
TableInfoCreateRequest renewTableInfo = new TableInfoCreateRequest("커찬 테이블", "주제");
List<TimeBoxCreateRequest> renewTimeBoxes = List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
);
ParliamentaryTableCreateRequest renewTableRequest = new ParliamentaryTableCreateRequest(
renewTableInfo,
renewTimeBoxes
new TableInfoCreateRequest("커찬의 테이블", "주제"),
List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
)
);

ParliamentaryTableResponse updatedTable = parliamentaryService.updateTable(renewTableRequest,
chanTable.getId(), chan);
parliamentaryService.updateTable(renewTableRequest, chanTable.getId(), chan);

Optional<ParliamentaryTable> updatedTable = parliamentaryTableRepository.findById(chanTable.getId());
List<ParliamentaryTimeBox> updatedTimeBoxes = timeBoxRepository.findAllByParliamentaryTable(
updatedTable.get());

assertAll(
() -> assertThat(updatedTable.id()).isEqualTo(chanTable.getId()),
() -> assertThat(updatedTable.info().name()).isEqualTo(renewTableInfo.name()),
() -> assertThat(updatedTable.table()).hasSize(renewTimeBoxes.size())
() -> assertThat(updatedTable.get().getId()).isEqualTo(chanTable.getId()),
() -> assertThat(updatedTable.get().getName()).isEqualTo(renewTableRequest.info().name()),
() -> assertThat(updatedTimeBoxes).hasSize(renewTableRequest.table().size())
);
}

Expand All @@ -118,14 +117,12 @@ class UpdateTable {
Member coli = memberGenerator.generate("콜리");
ParliamentaryTable chanTable = tableGenerator.generate(chan);
long chanTableId = chanTable.getId();
TableInfoCreateRequest renewTableInfo = new TableInfoCreateRequest("새로운 테이블", "주제");
List<TimeBoxCreateRequest> renewTimeBoxes = List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
);
ParliamentaryTableCreateRequest renewTableRequest = new ParliamentaryTableCreateRequest(
renewTableInfo,
renewTimeBoxes
new TableInfoCreateRequest("새로운 테이블", "주제"),
List.of(
new TimeBoxCreateRequest(Stance.PROS, BoxType.OPENING, 3, 1),
new TimeBoxCreateRequest(Stance.CONS, BoxType.OPENING, 3, 1)
)
);

assertThatThrownBy(() -> parliamentaryService.updateTable(renewTableRequest, chanTableId, coli))
Expand Down

0 comments on commit a83f68e

Please sign in to comment.