Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] DEV_CD 파이프라인 구축 + application-dev.yml 작성 #58

Merged
merged 25 commits into from
Jan 23, 2025

Conversation

coli-geonwoo
Copy link
Contributor

🚩 연관 이슈

closed #57

🗣️ 리뷰 요구사항 (선택)

  • cd 파이프라인을 땅콩 레퍼런스 참고하여 작성하였습니다.
  • RDS는 연결 확인하였고 테스트를 통해 정상작동 확인하였습니다.

Copy link

github-actions bot commented Jan 19, 2025

Test Results

73 tests   73 ✅  7s ⏱️
35 suites   0 💤
35 files     0 ❌

Results for commit 9bc50d3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 19, 2025

📝 Test Coverage Report

Overall Project 61.66%

There is no coverage information present for the Files changed

Copy link
Contributor

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noti
질문 하나 남겼어요~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트를 수행하지 않고 바로 배포하네요. 테스트를 수행하지 않아도 괜찮다고 판단한 이유가 궁금해요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다.

Copy link
Contributor

@leegwichan leegwichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noti 정상작동한다는 전제로 Approve 할께요
c.f.1 비토 코멘트 확인 부탁드려요~
c.f.2 나 리뷰 안하고 있으면 재촉 좀;;

@coli-geonwoo
Copy link
Contributor Author

/noti

DEV_CD에 테스트 작업 포함하였습니다!

Copy link
Contributor

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noti
LGTM
둘 다 approve했어요~

@coli-geonwoo coli-geonwoo merged commit 5950d03 into develop Jan 23, 2025
5 checks passed
@coli-geonwoo coli-geonwoo deleted the chore/#57 branch January 23, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 기타
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CHORE] Dev_CD 파이프라인 + application-dev.yml 파일 설정
3 participants