Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] CORS 설정 #68

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[FEAT] CORS 설정 #68

merged 2 commits into from
Jan 24, 2025

Conversation

leegwichan
Copy link
Contributor

🚩 연관 이슈

closed #65

🗣️ 리뷰 요구사항 (선택)

  • 작업 방향
    • application.yml 테스트 환경 분리했다.
    • CORS를 확인하는 Preflight 요청에 대한 테스트 추가했다.
  • 추가적으로 질문 사항 있으면, 언제든지 질문하세요
    • 단, 오늘 기능 확인해야해서 머지는 되어야 한다.

@unifolio0 unifolio0 added the feat 기능 추가 label Jan 24, 2025
Copy link

Test Results

75 tests   75 ✅  7s ⏱️
37 suites   0 💤
37 files     0 ❌

Results for commit 12b44c6.

Copy link

📝 Test Coverage Report

Overall Project 63.1%
Files changed 100% 🍏

File Coverage
CorsConfig.java 100% 🍏

Copy link
Contributor

@coli-geonwoo coli-geonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noti

짧은 시간이었는데 preflight 테스트까지 작성해주셨네요 커찬 ㄷㄷ

빠른 작업 감사합니다!

Copy link
Contributor

@unifolio0 unifolio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/noti
LGTM

@leegwichan leegwichan merged commit 3ee5ada into develop Jan 24, 2025
6 checks passed
@leegwichan leegwichan deleted the feat/#65 branch January 24, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] CORS 설정
3 participants